Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #6 -- Removes media volume from open notificaties #10

Merged
merged 3 commits into from
Jun 30, 2021
Merged

Fixes #6 -- Removes media volume from open notificaties #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0821e03
Fixes #8 -- Corrects mountPath of media in open zaak deployment
andyverberne Apr 29, 2021
5701de8
Fixes #6 -- Removes media volume from open notificaties
andyverberne Apr 29, 2021
d65433a
Fixes #6 -- Increment Helm chart version
andyverberne Apr 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/open-notificaties/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: open-notificaties
description: API voor het routeren van notificaties

type: application
version: 0.3.0
version: 0.3.1
appVersion: 1.1.0

dependencies:
Expand Down
3 changes: 0 additions & 3 deletions charts/open-notificaties/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,6 @@ helm install open-notificaties open-zaak/open-notificaties \
| `ingress.annotations` | Additional annotations on the API ingress | `{}` |
| `ingress.hosts` | Ingress hosts | `"{open-notificaties.gemeente.nl}"` |
| `ingress.tls` | Ingress TLS settings | `"[]"` |
| `persistence.enabled` | Enable persistency for application media | `false` |
| `persistence.size` | The size of the application media persistent volume | `"1Gi"` |
| `persistence.existingClaim` | Use an existing claim for application media | `null` |
| `settings.allowedHosts` | A comma-separated list of hosts allowed by the application | `"open-notificaties.gemeente.nl"` |
| `settings.secretKey` | The secret key of the application | `"SOME-RANDOM-SECRET"` |
| `settings.database.host` | The hostname of PostgreSQL | `"open-notificaties-postgresql"` |
Expand Down
11 changes: 0 additions & 11 deletions charts/open-notificaties/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,17 +62,6 @@ spec:
{{- toYaml .Values.readinessProbe | nindent 12 }}
resources:
{{- toYaml .Values.resources | nindent 12 }}
volumeMounts:
- name: media
mountPath: /media
volumes:
- name: media
{{- if .Values.persistence.enabled }}
persistentVolumeClaim:
claimName: {{ if .Values.persistence.existingClaim }}{{ .Values.persistence.existingClaim }}{{- else }}{{ include "open-notificaties.fullname" . }}{{- end }}
{{- else }}
emptyDir: {}
{{- end }}
{{- with .Values.nodeSelector }}
nodeSelector:
{{- toYaml . | nindent 8 }}
Expand Down
14 changes: 0 additions & 14 deletions charts/open-notificaties/templates/pvc.yaml
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions charts/open-notificaties/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,11 +87,6 @@ tolerations: []

affinity: {}

persistence:
enabled: false
size: 1Gi
existingClaim: null

worker:
replicaCount: 1
resources: {}
Expand Down
2 changes: 1 addition & 1 deletion charts/open-zaak/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ spec:
{{- toYaml .Values.resources | nindent 12 }}
volumeMounts:
- name: media
mountPath: /media
mountPath: /app/private-media
volumes:
- name: media
{{- if .Values.persistence.enabled }}
Expand Down