Fix fungibles unbalanced #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #823 +/- ##
==========================================
+ Coverage 78.24% 78.37% +0.13%
==========================================
Files 102 102
Lines 10129 10191 +62
==========================================
+ Hits 7925 7987 +62
Misses 2204 2204
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xlc
approved these changes
Oct 27, 2022
shaunxw
approved these changes
Oct 27, 2022
|
See my comments on the related changes in the Substrate PR |
zjb0807
commented
Oct 30, 2022
Comment on lines
+125
to
+128
| assert_eq!( | ||
| <Tokens as fungibles::Unbalanced<_>>::decrease_balance_at_most(DOT, &ALICE, 60), | ||
| 0 | ||
| ); |
There was a problem hiding this comment.
This should succeed and return 50
Closed
xlc
pushed a commit
that referenced
this pull request
Nov 7, 2022
* Add fungibles::Unbalanced tests * fix set_balance
xlc
added a commit
that referenced
this pull request
Nov 7, 2022
* Fix fungibles unbalanced (#823) * Add fungibles::Unbalanced tests * fix set_balance * run CI for release branch Co-authored-by: zjb0807 <zjb0807@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #821
https://github.com/paritytech/substrate/blob/696bdc67af5fd83aca318263dbd405593b043ba3/frame/support/src/traits/tokens/fungibles/balanced.rs#L182-L239