-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distinguish when MinXcmFee
is not registered and FeeNotEnough
#753
Distinguish when MinXcmFee
is not registered and FeeNotEnough
#753
Conversation
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
MinXcmFee
is not registered and FeeNotEnough
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
please use |
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
should be clean now. |
Test is failing |
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Btw I have a related test case that I'm not sure if it's an issue in my setup or the xtokens code. The case is the following: |
I don't really get it. Can you share the failing test? |
Yeah take a look at this test in our repo - https://github.com/Manta-Network/Manta/blob/bac7e321b14d4abcfb2ca1f5809a7e9f0cb8f065/runtime/common/tests/xcm_tests.rs#L2599-L2776. It's a little long but essentially register ParaA native asset, ParaB native asset, and relay asset on both ParaA and and ParaB. Also registers You can see from the asserts on both ParaA and ParaB that things work correctly when If you change |
I think your testcase is same as: open-runtime-module-library/xtokens/src/tests.rs Lines 717 to 778 in 3576772
sender should make sure using enough relaychain token as fee. |
|
Also why do we need to subtract |
If we send all fee_amount to relaychain, then there're none left relaychain token used to send direct to Statemine, But Statemine current only support relaychain token to buy execution fee, so this xcm execution will failed. |
Yes, of-course, thanks for re-explaining the code. For a minute there I though that |
Signed-off-by: Georgi Zlatarev georgi.zlatarev@manta.network
A few small changes to improve debugging and readability:
MinXcmFee
is not registered, to distinguish between this case andFeeNotEnough
MinXcmFee
return an Option, so implementers don't have to use u128::Max for unregistered locations.