v0.9.9 deps #588
Merged
v0.9.9 deps #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaunxw
commented
Aug 23, 2021
| ) => { | ||
| pub struct Benchmark; | ||
|
|
||
| impl $crate::Benchmarking<$crate::BenchmarkResults> for Benchmark { | ||
| fn benchmarks(extra: bool) -> $crate::Vec<&'static [u8]> { | ||
| let mut all = $crate::vec![ $( stringify!($name).as_ref() ),* ]; | ||
| fn benchmarks(extra: bool) -> $crate::Vec<$crate::BenchmarkMetadata> { |
There was a problem hiding this comment.
this fn is one of the changes in benchmarking, and we may need to check latest frame-branchmarking impl, to follow the improvements and updates. then redo benches before next runtime release. could be done in another PR
xlc
approved these changes
Aug 23, 2021
|
thanks @shaunxw ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.