Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: special chars in filename break file sending in docker image #3071

Closed
smashah opened this issue Mar 23, 2023 · 1 comment
Closed

bug: special chars in filename break file sending in docker image #3071

smashah opened this issue Mar 23, 2023 · 1 comment
Labels
PRIORITY Fast track for BMAC Members only.

Comments

@smashah
Copy link
Member

smashah commented Mar 23, 2023

Doesn't work:

{
  "args": {
    "to": "1111@c.us",
    "file": "https://www.africau.edu/images/default/sample.pdf",
    "filename": "testé.pdf",
    "waitForId": true
  }
}

Works:

{
  "args": {
    "to": "1111@c.us",
    "file": "https://www.africau.edu/images/default/sample.pdf",
    "filename": "test.pdf",
    "waitForId": true
  }
}

The sendfile(image) process fails on the uploadFile stage within the docker container.

Fix:

Sanitize the filename only when creating the temp file and uploading the file. Use the original filename when sending the file via wapi.

@smashah
Copy link
Member Author

smashah commented Mar 23, 2023

fixed in 4.59.0

#3070 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PRIORITY Fast track for BMAC Members only.
Projects
None yet
Development

No branches or pull requests

1 participant