-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add is_array filter and test for AttributeType #540
Open
arthurDiff
wants to merge
8
commits into
open-telemetry:main
Choose a base branch
from
arthurDiff:add-is_array-to-attributetype
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
545aa8d
Add is_array filter and test for AttributeType
arthurDiff 7860ebc
Revert "Add is_array filter and test for AttributeType"
arthurDiff f61d62a
add is_array with minijinja impl
arthurDiff 02f4eef
Merge branch 'main' into add-is_array-to-attributetype
lquerel ed60aa5
documentation update and one additional test case
arthurDiff 2e48618
Merge branch 'add-is_array-to-attributetype' of https://github.com/ar…
arthurDiff bc446ae
readme spacing fix to keep consistent from prev
arthurDiff 7459fa0
updating is_array criteria
arthurDiff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lmolkova This test looks fine to me, but could you confirm: for
semconvs
, should atemplate[xxx[]]
be considered an array, or should we treat any template as not being an array, even when templating an array of something?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just added in documentation update and new test case for full coverage! just let me know if that needs updating!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for checking! Templates are not really arrays, they are more like a maps - we also have a filter that checks if attribute has a template -
is_template_type
, so I believeis_array
should be limited toThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other that that, it looks great to me, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha! thanks for the clarification! I just updated to those criteria! @lquerel @lmolkova