Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize migration requirement for stable database semconv #992

Merged
merged 8 commits into from
May 9, 2024

Conversation

trask
Copy link
Member

@trask trask commented May 1, 2024

Fixes #719

Changes

Finalizes the migration requirement for instrumentations to follow when updating to stable database semconv.

@trask trask marked this pull request as ready for review May 1, 2024 20:45
@trask trask requested review from a team May 1, 2024 20:45
@pyohannes
Copy link
Contributor

Warning
Existing Database instrumentations that are using
v1.20.0 of this document
(or prior):

  • SHOULD NOT change the version of the networking conventions that they emit
    until the HTTP semantic conventions are marked stable (HTTP stabilization will
    include stabilization of a core set of networking conventions which are also used
    in Database instrumentations).

Does it makes sense that this part still coexists with the warning proposed in this PR?

If I understand correctly, this would require users to set both OTEL_SEMCONV_STABILITY_OPT_IN=database,http to reliably get data according to new (stable) conventions?

pyohannes pushed a commit to pyohannes/semantic-conventions that referenced this pull request May 3, 2024
pyohannes pushed a commit to pyohannes/semantic-conventions that referenced this pull request May 3, 2024
Copy link
Member

@gregkalapos gregkalapos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit - somewhat related to @pyohannes's comment. In the http docs in the part about OTEL_SEMCONV_STABILITY_OPT_IN it currently says:

The only values defined so far are:

If these new values are added due to DB, I think that sentence should be removed from the http docs.

docs/database/database-metrics.md Outdated Show resolved Hide resolved
@trask
Copy link
Member Author

trask commented May 7, 2024

Does it makes sense that this part still coexists with the warning proposed in this PR?

good point, it does make it much more confusing

I've removed the http part. That part still exists in prior tags, so still can apply if someone is upgrading to earlier version of semconv.

@trask trask assigned trask and unassigned jsuereth May 8, 2024
@lmolkova lmolkova enabled auto-merge (squash) May 9, 2024 17:03
@lmolkova lmolkova merged commit c316b1f into open-telemetry:main May 9, 2024
12 checks passed
drewby pushed a commit to drewby/otel-semantic-conventions that referenced this pull request May 23, 2024
@trask trask deleted the migration branch October 14, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
5 participants