-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize migration requirement for stable database semconv #992
Conversation
Does it makes sense that this part still coexists with the warning proposed in this PR? If I understand correctly, this would require users to set both |
… to set `null` as undefined behavior (open-telemetry#992)
… to set `null` as undefined behavior (open-telemetry#992)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit - somewhat related to @pyohannes's comment. In the http
docs in the part about OTEL_SEMCONV_STABILITY_OPT_IN
it currently says:
The only values defined so far are:
If these new values are added due to DB, I think that sentence should be removed from the http docs.
good point, it does make it much more confusing I've removed the http part. That part still exists in prior tags, so still can apply if someone is upgrading to earlier version of semconv. |
Fixes #719
Changes
Finalizes the migration requirement for instrumentations to follow when updating to stable database semconv.