Add attribute for k8s pod annotations #573
Merged
+36
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
dashpole
reviewed
Dec 1, 2023
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
dashpole
approved these changes
Dec 5, 2023
TylerHelmuth
approved these changes
Dec 5, 2023
jinja2
approved these changes
Dec 5, 2023
|
@open-telemetry/specs-semconv-approvers @open-telemetry/specs-semconv-maintainers could you have a look please? |
pyohannes
reviewed
Dec 6, 2023
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
|
Based on the discussion at #573 (comment) I have updated this PR to make the annotations attribute singular. |
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
pyohannes
approved these changes
Dec 11, 2023
AlexanderWert
approved these changes
Dec 13, 2023
TylerHelmuth
approved these changes
Dec 13, 2023
trask
approved these changes
Dec 13, 2023
pyohannes
pushed a commit
to pyohannes/semantic-conventions
that referenced
this pull request
Jan 17, 2024
Signed-off-by: ChrsMark <chrismarkou92@gmail.com> Co-authored-by: Alexander Wert <AlexanderWert@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This adds support for pod's annotations to k8s.pod resource.
ref: #494 (comment)
Merge requirement checklist