-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change network.transport
from recommended to opt-in in the HTTP semconv
#402
Change network.transport
from recommended to opt-in in the HTTP semconv
#402
Conversation
587e614
to
0b9c69e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
It was pretty much always skipped anyway:
If not default (
tcp
forHTTP/1.1
andHTTP/2
,udp
forHTTP/3
).
Actually this is not true. In Node.js scenarios I think it is not entirely unheard of to communicate with a local HTTP server over Unix domain sockets. We have seen this in the wild with our agents I believe |
Looking for
I agree it's a valid concern, but having this attribute outside of HTTP spec and effectively opt-in still works. |
network.transport
from HTTP semconv, effectively making it opt-innetwork.transport
from recommended to opt-in in the HTTP semconv
…conv (open-telemetry#402) Co-authored-by: Joao Grassi <joao.grassi@dynatrace.com>
Fixes #389
network.transport
is typically derivable fromnetwork.protocol.version
:tcp
udp
so it doesn't provide much value to capture in HTTP semconv.
Changes
Change
network.transport
from recommended to opt-in in the HTTP semconv.Merge requirement checklist
schema-next.yaml updated with changes to existing conventions.