Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move RPC streaming notes from metric brief section to notes section #275

Merged
merged 6 commits into from
Sep 11, 2023

Conversation

trask
Copy link
Member

@trask trask commented Aug 21, 2023

Noticed while investigating open-telemetry/opentelemetry-demo#969.

I'm making an assumption that the brief should be a more concise, basic definition.

Changes

Moved RPC streaming notes from metric brief section to notes section.

Merge requirement checklist

@trask trask changed the title Move streaming note to notes section Move RPC streaming notes from metric brief section to notes section Aug 21, 2023
@trask trask force-pushed the better-description branch from e27e9f0 to b37d755 Compare August 21, 2023 18:40
@trask trask force-pushed the better-description branch from b37d755 to ef58a16 Compare August 21, 2023 18:45
@trask trask marked this pull request as ready for review August 21, 2023 18:45
@trask trask requested review from a team August 21, 2023 18:45
@trask trask mentioned this pull request Aug 21, 2023
3 tasks
Copy link
Member

@joaopgrassi joaopgrassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much nicer, thanks!

@julianocosta89
Copy link
Member

@open-telemetry/specs-semconv-approvers, @open-telemetry/specs-semconv-maintainers can we get that merged?

@jsuereth jsuereth merged commit d7930d3 into open-telemetry:main Sep 11, 2023
@trask trask deleted the better-description branch October 14, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants