-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move RPC streaming notes from metric brief section to notes section #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
changed the title
Move streaming note to notes section
Move RPC streaming notes from metric brief section to notes section
Aug 21, 2023
trask
force-pushed
the
better-description
branch
from
August 21, 2023 18:40
e27e9f0
to
b37d755
Compare
trask
force-pushed
the
better-description
branch
from
August 21, 2023 18:45
b37d755
to
ef58a16
Compare
This was referenced Aug 21, 2023
Closed
joaopgrassi
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much nicer, thanks!
julianocosta89
approved these changes
Sep 8, 2023
@open-telemetry/specs-semconv-approvers, @open-telemetry/specs-semconv-maintainers can we get that merged? |
AlexanderWert
approved these changes
Sep 11, 2023
jsuereth
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while investigating open-telemetry/opentelemetry-demo#969.
I'm making an assumption that the
brief
should be a more concise, basic definition.Changes
Moved RPC streaming notes from metric brief section to notes section.
Merge requirement checklist
schema-next.yaml updated with changes to existing conventions.