-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Consolidate genai.request.seed #1683
base: main
Are you sure you want to change the base?
Conversation
It is weird, I can see the dead link can actually be accessed https://web.archive.org/web/20180321091318/http://www.onlamp.com/pub/a/linux/2000/11/16/LinuxAdmin.html |
@gyliu513 thanks for the contribution! The markdown tables are auto-generated from yaml definitions - please check https://github.com/open-telemetry/semantic-conventions/blob/main/CONTRIBUTING.md#1-modify-the-yaml-model for more details. Also, we don't remove attributes, we deprecate them - you can find some examples in the https://github.com/open-telemetry/semantic-conventions/blob/main/model/gen-ai/deprecated/registry-deprecated.yaml We'll also need a changelog record for it - you can find more details on how to create one in https://github.com/open-telemetry/semantic-conventions/blob/main/CONTRIBUTING.md#4-changelog. |
ea39a9b
to
86bbc5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Left a few minor comments.
Please also update the https://github.com/open-telemetry/semantic-conventions/blob/main/schema-next.yaml - add the following under version 1.29.0
# https://github.com/open-telemetry/semantic-conventions/pull/1683
- rename_attributes:
attribute_map:
gen_ai.openai.request.seed: gen_ai.request.seed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lmolkova , all comments are addressed.
Signed-off-by: Guangya Liu <gyliu@ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for this!
Fixes #
This is a follow up for https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3081/files#r1884746832
/cc @lmolkova @lzchen
Changes
Please provide a brief description of the changes here.
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
[chore]