Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark .NET runtime metrics as stable #1609

Merged

Conversation

stevejgordon
Copy link
Contributor

@stevejgordon stevejgordon commented Nov 25, 2024

Fixes #1602

NOTE: dotnet.process.cpu.time remains experimental due to its dependency on cpu.time.

Merge requirement checklist

@stevejgordon stevejgordon requested review from a team as code owners November 25, 2024 08:49
@stevejgordon stevejgordon marked this pull request as draft November 25, 2024 08:50
@stevejgordon stevejgordon marked this pull request as ready for review November 25, 2024 09:30
@stevejgordon
Copy link
Contributor Author

cc @lmolkova

Copy link
Contributor

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Left a couple of small comments on cpu.mode stability.

I can follow up on the https://github.com/open-telemetry/semantic-conventions/pull/1609/files#r1857409091 if you want.

@stevejgordon stevejgordon requested a review from a team as a code owner November 26, 2024 11:10
Copy link
Contributor

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lmolkova lmolkova merged commit 41053b5 into open-telemetry:main Dec 3, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Mark .NET runtime metrics as stable
4 participants