-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add section on span status for databases #1560
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
reviewed
Nov 8, 2024
lmolkova
commented
Nov 8, 2024
trask
reviewed
Nov 8, 2024
trask
reviewed
Nov 8, 2024
lmolkova
force-pushed
the
database-span-status
branch
from
November 8, 2024 18:03
b4a9c3a
to
566bf08
Compare
16 tasks
trask
approved these changes
Nov 10, 2024
maryliag
reviewed
Nov 13, 2024
joaopgrassi
reviewed
Nov 13, 2024
lmolkova
force-pushed
the
database-span-status
branch
from
November 19, 2024 23:12
964fdfd
to
dd03562
Compare
lmolkova
commented
Nov 19, 2024
maryliag
previously approved these changes
Nov 25, 2024
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
lmolkova
force-pushed
the
database-span-status
branch
from
November 25, 2024 19:12
8a2a33c
to
a3d0677
Compare
maryliag
approved these changes
Nov 26, 2024
jsuereth
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the DB part of #1536.
Let's polish it for databases and then expand to other conventions (and potentially have a generic guidance).
The intention is to keep exception event part experimental since
Merge requirement checklist
[chore]