Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SHOULD instead of MUST for span kinds on DB, GenAI and FaaS #1506

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Oct 22, 2024

Fixes #1315

Changes

Relaxes DB, GenAI and FaaS span kind conventions to use SHOULD instead of MUST.
A good justification for this would be in-memory db or gen-ai model running in the same process.

Since there are a lot of variations of FaaS spans and they usually follow some other conventions (HTTP or messaging) their span kinds can't be too strict.

Merge requirement checklist

@lmolkova lmolkova requested review from a team as code owners October 22, 2024 02:05
@lmolkova lmolkova requested a review from a team as a code owner October 23, 2024 17:53
@lmolkova lmolkova enabled auto-merge (squash) October 23, 2024 17:57
@lmolkova lmolkova disabled auto-merge October 23, 2024 17:59
@joaopgrassi joaopgrassi merged commit 1050236 into open-telemetry:main Oct 24, 2024
14 checks passed
Copy link

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

post-merge approve. I completely agree that in-process (possibly also IPC) being able to mark themselves INTERNAL is a step forward!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Allow INTERNAL GenAI/db spans instead of requiring the kind to be CLIENT
9 participants