-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DB: fix how operation and collection names are recorded for complex queries (opt-in db.query.text
on metrics, new db.query.summary
recommended attribute)
#1482
Conversation
db.query.text
on DB client duration metricdb.query.text
on metrics, new db.query.synthetic
recommended attribute)
some possibilities for naming:
|
I really like the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm 👍 on this
db.query.text
on metrics, new db.query.synthetic
recommended attribute)db.query.text
on metrics, new db.query.summary
recommended attribute)
c27b092
to
004a94d
Compare
004a94d
to
9fb01e2
Compare
08c1d7d
to
ed441ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌟
…to record single value
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
78cce84
to
457d6dc
Compare
Fixes #1159, #805
Related: #521
Based on the discussion on slack https://cloud-native.slack.com/archives/C06HH05KNMC/p1728891505239829 and spec discussion on 10/25/24:
We can however:
db.query.text
as opt-in to mitigate shortcomings of single operation/collection name.SELECT foo, UPDATE bar, DELETE bar
- it'd have low-ish cardinality, would be shorter than a query, won't have any sensitive information that needs sanitization and would be readable enough. This allows to make it recommended on metrics.This PR implements both options as discussed in #805 (comment)
Merge requirement checklist
[chore]
schema-next.yaml updated with changes to existing conventions.