Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change messaging.operation.type=publish to send #1422

Merged
merged 12 commits into from
Oct 7, 2024

Conversation

mamwl1
Copy link
Contributor

@mamwl1 mamwl1 commented Sep 20, 2024

Fixes #1285

Changes

Change messaging.operation.type=publish to send, as well as the related messaging.client.published.messages metric. Adjust text to use send where appropriate. Update example to use send where appropriate.

Merge requirement checklist

@mamwl1 mamwl1 requested review from a team as code owners September 20, 2024 11:40
Copy link

linux-foundation-easycla bot commented Sep 20, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@mamwl1 mamwl1 closed this Sep 20, 2024
@mamwl1
Copy link
Contributor Author

mamwl1 commented Sep 20, 2024

Closing while CLA is being sorted which might take some time.

@mamwl1 mamwl1 reopened this Oct 2, 2024
Copy link
Member

@joaopgrassi joaopgrassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I think there are still some "publish" left-overs we need to tackle.

docs/messaging/gcp-pubsub.md Show resolved Hide resolved
docs/messaging/kafka.md Show resolved Hide resolved
docs/messaging/messaging-spans.md Show resolved Hide resolved
docs/messaging/messaging-spans.md Show resolved Hide resolved
docs/messaging/messaging-spans.md Outdated Show resolved Hide resolved
@joaopgrassi
Copy link
Member

Heads up: If #1446 merges first, we will need to adapt the new example introduced there.

@lmolkova lmolkova enabled auto-merge (squash) October 7, 2024 17:12
@lmolkova lmolkova merged commit f9cf635 into open-telemetry:main Oct 7, 2024
14 checks passed
@mamwl1 mamwl1 deleted the mamwl1_branch branch October 8, 2024 08:47
ChrsMark pushed a commit to ChrsMark/semantic-conventions that referenced this pull request Oct 18, 2024
Co-authored-by: Joao Grassi <5938087+joaopgrassi@users.noreply.github.com>
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Messaging: publish operation type is pub/sub/topic specific
3 participants