Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add system.device attribute to system paging metrics #1408

Merged
merged 5 commits into from
Oct 15, 2024
Merged

Add system.device attribute to system paging metrics #1408

merged 5 commits into from
Oct 15, 2024

Conversation

rogercoll
Copy link
Contributor

Fixes #1407

Changes

Reference system.device in system paging usage metrics.

Merge requirement checklist

@rogercoll rogercoll requested review from a team September 16, 2024 15:07
@rogercoll rogercoll requested a review from a team September 16, 2024 15:26
@rogercoll
Copy link
Contributor Author

CI will be fixed with #1412

@rogercoll rogercoll mentioned this pull request Sep 26, 2024
Closed
@ChrsMark ChrsMark mentioned this pull request Oct 3, 2024
Closed
5 tasks
@lmolkova lmolkova mentioned this pull request Oct 14, 2024
Open
lmolkova
lmolkova approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

(And sorry for the confusion - I created #1474 to follow up on the system.device)

.chloggen/add_paging_device_attr.yaml Outdated Show resolved Hide resolved
@lmolkova lmolkova enabled auto-merge (squash) October 14, 2024 14:51
@joaopgrassi joaopgrassi disabled auto-merge October 15, 2024 08:27
@joaopgrassi joaopgrassi requested review from a team as code owners October 15, 2024 08:27
@joaopgrassi joaopgrassi merged commit d89ada7 into open-telemetry:main Oct 15, 2024
14 of 15 checks passed
@rogercoll rogercoll deleted the add_paging_device_attr branch October 15, 2024 08:57
ChrsMark pushed a commit to ChrsMark/semantic-conventions that referenced this pull request Oct 18, 2024
@rogercoll @joaopgrassi @ChrsMark
Add system.device attribute to system paging metrics (open-telemetry#…
1faf5f8 
…1408)

Co-authored-by: Joao Grassi <5938087+joaopgrassi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LikeTheSalad LikeTheSalad LikeTheSalad left review comments

@ChrsMark ChrsMark ChrsMark approved these changes

@joaopgrassi joaopgrassi joaopgrassi approved these changes

@mx-psi mx-psi mx-psi approved these changes

@lmolkova lmolkova lmolkova approved these changes

Assignees
No one assigned
Labels
area:system
Projects
Semantic Conventions Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add system.device attribute to system paging metrics
7 participants
@rogercoll @lmolkova @mx-psi @joaopgrassi @ChrsMark @LikeTheSalad @reyang