Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add YAML definitions for log semantic conventions and define requirement levels #133

Merged
merged 9 commits into from
Jun 30, 2023

Conversation

ChrsMark
Copy link
Member

This PR moves the logs definitions from media.md to a respective media.yaml. The markdown tables are also dynamically re-generated.

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark requested a review from tigrannajaryan June 27, 2023 08:32
@arminru arminru requested a review from joaopgrassi June 27, 2023 11:47
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
semantic_conventions/logs/media.yaml Outdated Show resolved Hide resolved
semantic_conventions/logs/media.yaml Outdated Show resolved Hide resolved
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Copy link
Member

@joaopgrassi joaopgrassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ChrsMark !

semantic_conventions/logs/media.yaml Outdated Show resolved Hide resolved
ChrsMark added 2 commits June 29, 2023 11:21
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark
Copy link
Member Author

I guess we can merge this one? (I don't have permissions to merge :)).

@arminru arminru requested review from a team June 30, 2023 09:58
@arminru arminru changed the title Add log yaml spec Add YAML definitions for log semantic conventions and define requirement levels Jun 30, 2023
@arminru arminru merged commit afc8123 into open-telemetry:main Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants