Add policy enforcement for attribute registry. #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add REGO rules to enforce attribute registry things. - Add diagnostic rendering to improve error messages on attribute registry failure. Example failure: ``` $ make check-policies ✔ SemConv registry loaded (138 files) ✔ SemConv registry resolved Semantic Convention Model Validation Failures: /source/metrics/jvm-metrics.yaml: Attribute jvm.memory.bad_name cannot be defined in Group attributes.jvm.memory Attribute Group not in Attribute Registry. ```
lmolkova
approved these changes
Jul 3, 2024
lmolkova
reviewed
Jul 3, 2024
lmolkova
reviewed
Jul 3, 2024
trisch-me
reviewed
Jul 4, 2024
joaopgrassi
approved these changes
Jul 22, 2024
maryliag
pushed a commit
to maryliag/semantic-conventions
that referenced
this pull request
Jul 30, 2024
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
registry failure.
Example failure:
Replaces #1014