Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify case normalization in db spec #1004

Merged
merged 4 commits into from
May 7, 2024

Conversation

gregkalapos
Copy link
Member

@gregkalapos gregkalapos commented May 3, 2024

Fixes #886

Changes

Adding note about case normalization to following attributes:

  • db.collection.name
  • db.namespace
  • db.operation.name

The added note suggested in #886

It is RECOMMENDED to capture the value as provided by the application without attempting to do any case normalization.

Merge requirement checklist

@gregkalapos gregkalapos requested review from a team May 3, 2024 15:20
@gregkalapos gregkalapos changed the title Clarify case normalization in db spec [chore] Clarify case normalization in db spec May 3, 2024
@trask
Copy link
Member

trask commented May 7, 2024

I think probably needs a change log

@gregkalapos gregkalapos changed the title [chore] Clarify case normalization in db spec Clarify case normalization in db spec May 7, 2024
@gregkalapos
Copy link
Member Author

CI fails with:

34s
Run make markdown-link-check
  make markdown-link-check
  shell: /usr/bin/bash -e {0}
fatal: No names found, cannot describe anything.
semantic-conventions@ /home/runner/work/semantic-conventions/semantic-conventions
└── markdown-link-check@3.11.2


  ERROR: 1 dead links found in ./docs/attributes-registry/db.md !
  [✖] https://docs.datastax.com/en/cassandra-oss/3.0/cassandra/dml/dmlConfigConsistency.html → Status: 404
make: *** [Makefile:47: markdown-link-check] Error 1
Error: Process completed with exit code 2.

That link works from my browser - and the PR doesn't really change anything around it. Strange. Trying to figure this out.

@lmolkova lmolkova merged commit 5c3e4f1 into open-telemetry:main May 7, 2024
11 of 12 checks passed
drewby pushed a commit to drewby/otel-semantic-conventions that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Case normalization in db.name, db.collection.name, db.operation.name?
4 participants