-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request to create semconv-{container,k8s}-approvers #427
Comments
I am interested in joining. I would also like to nominate @jinja2 who has been a tremendous source of Kubernetes knowledge for the Collector components. |
Awesome @TylerHelmuth , I have added you both :)! |
Thank you, @ChrsMark! |
Additional related issue: #430 |
I think this is a little to broad of a scope. E.g. are you going to be owning every semconv for technology coming from CNCF, including otel itself? Let's alter the name to denote some limits, e.g.
I think it makes sense for us to keep the two lists separate even if it's the same set of folks initially. |
Thank's @jsuereth , that makes sense! I can split the group into 2 different groups then. |
I'd like to nominate myself for the k8s-approvers group. |
@ChrsMark yes, please add me in |
I created @open-telemetry/semconv-container-approvers and added the following members: @mlunadia I was not able to add you as you are not a member of the OpenTelemetry organization yet. |
@open-telemetry/semconv-container-approvers and @open-telemetry/semconv-k8s-approvers you can go ahead and update https://github.com/open-telemetry/semantic-conventions/blob/main/.github/CODEOWNERS to add OWNERS for the relevant subdirectories. |
@arminru I have now my membership and have requested to join. Thanks! |
@arminru just checking if you can add me to the approvers for both of these groups. |
Hi @mlunadia! |
I'd like to request creating 2 new approvers groups
semconv-container-approvers
andsemconv-k8s-approvers
(as per suggestion at #427 (comment)) that would be responsible for reviewing and maintaining semantic conventions related to the containers' and kubernetess areas respectively.Folks proposed for that groups / interested:
semconv-container-approvers
:semconv-k8s-approvers
:Related PRs and issues:
The text was updated successfully, but these errors were encountered: