Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP client-server example incorrect #1541

Closed
arminru opened this issue Oct 31, 2024 · 0 comments · Fixed by #1542
Closed

HTTP client-server example incorrect #1541

arminru opened this issue Oct 31, 2024 · 0 comments · Fixed by #1542
Labels
area:http bug Something isn't working

Comments

@arminru
Copy link
Member

arminru commented Oct 31, 2024

Area(s)

area:http

What happened?

The latest HTTP client-server example at https://github.com/open-telemetry/semantic-conventions/blob/v1.28.0/docs/http/http-spans.md#http-client-server-example incorrectly mentions an attribute client.socket.address.

As per #342 this should be network.peer.address instead.

Semantic convention version

1.28.0 and main

Additional context

No response
@arminru arminru added bug Something isn't working triage:needs-triage labels Oct 31, 2024
arminru added a commit to dynatrace-oss-contrib/semantic-conventions that referenced this issue Oct 31, 2024
@arminru
Fix HTTP client-server example
9b81c91 
Fixes open-telemetry#1541.

As per open-telemetry#342 this should be `network.peer.address` instead.
@arminru arminru mentioned this issue Oct 31, 2024
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in Spec: HTTP Semantic Conventions Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:http bug Something isn't working
Projects
Spec: HTTP Semantic Conventions
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[chore] Fix HTTP client-server example dynatrace-oss-contrib/semantic-conventions
2 participants
@joaopgrassi @arminru