Skip to content

Commit

Permalink
Update CHANGELOG.md and container.md
Browse files Browse the repository at this point in the history
  • Loading branch information
marcsanmi committed Jun 27, 2023
1 parent 0a56cde commit ea16261
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,8 @@ Note: This is the first release of Semantic Conventions separate from the Specif
([#105](https://github.com/open-telemetry/semantic-conventions/pull/105))
- Add container `image.id`, `command`, `command_line` and `command_args` resource attributes.
([#39](https://github.com/open-telemetry/semantic-conventions/pull/39))
- Add container `image.id`, `command`, `command_line` and `command_args` resource attributes.
([#39](https://github.com/open-telemetry/semantic-conventions/pull/39))

## v1.20.0 (2023-04-07)

Expand Down
4 changes: 2 additions & 2 deletions specification/resource/semantic_conventions/container.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@
| `container.command_line` | string | The full command run by the container as a single string representing the full command. [2] | `otelcontribcol --config config.yaml` | Opt-In |
| `container.command_args` | string[] | All the command arguments (including the command/executable itself) run by the container. [2] | `[otelcontribcol, --config, config.yaml]` | Opt-In |

**[1]:** Docker defines a sha256 of the image id; `container.image.id` corresponds to the `Image` field from the Docker container inspect [API](https://docs.docker.com/engine/api/v1.43/#tag/Container/operation/ContainerInspect) endpoint.
**[1]:** Docker defines a sha256 of the image id; `container.image.id` corresponds to the `Image` field from the Docker container inspect [API](https://docs.docker.com/engine/api/v1.43/#tag/Container/operation/ContainerInspect) endpoint.
K8s defines a link to the container registry repository with digest `"imageID": "registry.azurecr.io /namespace/service/dockerfile@sha256:bdeabd40c3a8a492eaf9e8e44d0ebbb84bac7ee25ac0cf8a7159d25f62555625"`.
OCI defines a digest of manifest.

**[2]:** If using embedded credentials or sensitive data, it is recommended to remove them to prevent potential leakage.
<!-- endsemconv -->

[DocumentStatus]: https://github.com/open-telemetry/opentelemetry-specification/blob/v1.21.0/specification/document-status.md
[DocumentStatus]: https://github.com/open-telemetry/opentelemetry-specification/blob/v1.21.0/specification/document-status.md

0 comments on commit ea16261

Please sign in to comment.