Skip to content

Commit

Permalink
more review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
lmolkova committed Sep 5, 2023
1 parent b4740ef commit a1f681f
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions docs/http/http-spans.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,18 +63,18 @@ and various HTTP versions like 1.1, 2 and SPDY.

HTTP spans MUST follow the overall [guidelines for span names](https://github.com/open-telemetry/opentelemetry-specification/tree/v1.22.0/specification/trace/api.md#span).

HTTP server span names SHOULD be `{method} {http.route}` (see below for the exact definition of the method placeholder) if there is a
HTTP server span names SHOULD be `{method} {http.route}` (see below for the exact definition of the `{method}` placeholder) if there is a
(low-cardinality) `http.route` available,

If there is no (low-cardinality) `http.route` available, HTTP server span names
SHOULD be `{method}` (see below for the exact definition of the method placeholder)
SHOULD be `{method}` (see below for the exact definition of the `{method}` placeholder)

HTTP client spans have no `http.route` attribute since client-side instrumentation
is not generally aware of the "route", and therefore HTTP client spans SHOULD be
`{method}`.

The `{method}` SHOULD be `{http.request.method}` if the method represents the original method known to the instrumentation.
In other cases (when `{http.request.method}` is set to `_OTHER`), `{method}` SHOULD match `HTTP`.
The `{method}` MUST be `{http.request.method}` if the method represents the original method known to the instrumentation.
In other cases (when `{http.request.method}` is set to `_OTHER`), `{method}` MUST be `HTTP`.

Instrumentation MUST NOT default to using URI
path as span name, but MAY provide hooks to allow custom logic to override the
Expand Down

0 comments on commit a1f681f

Please sign in to comment.