review comments

docs/messaging/kafka.md

@@ -27,6 +27,7 @@ For Apache Kafka, the following additional attributes are defined:
 <!-- semconv messaging.kafka(full,tag=tech-specific) -->
 | Attribute  | Type | Description  | Examples  | Requirement Level |
 |---|---|---|---|---|
+| [`messaging.destination.partition.id`](../attributes-registry/messaging.md) | string | "String representation of the partition id the message  (or batch) is sent to or received from."" | `1` | Recommended |
 | [`messaging.kafka.consumer.group`](../attributes-registry/messaging.md) | string | Name of the Kafka Consumer Group that is handling the message. Only applies to consumers, not producers. | `my-group` | Recommended |
 | [`messaging.kafka.message.key`](../attributes-registry/messaging.md) | string | Message keys in Kafka are used for grouping alike messages to ensure they're processed on the same partition. They differ from `messaging.message.id` in that they're not unique. If the key is `null`, the attribute MUST NOT be set. [1] | `myKey` | Recommended |
 | [`messaging.kafka.message.offset`](../attributes-registry/messaging.md) | int | The offset of a record in the corresponding Kafka partition. | `42` | Recommended |

docs/messaging/messaging-spans.md

@@ -343,7 +343,7 @@ size should be used.
 **[13]:** If a custom value is used, it MUST be of low cardinality.
 
 **[14]:** Semantic conventions for individual messaging systems SHOULD document whether `network.peer.*` attributes are applicable.
-Network peer address and port are important when the application interacts with individual intermediary nodes directly
+Network peer address and port are important when the application interacts with individual intermediary nodes directly,
 If a messaging operation involved multiple network calls (for example retries), the address of the last contacted node SHOULD be used.
 
 **[15]:** Server domain name of the broker if available without reverse DNS lookup; otherwise, IP address or Unix domain socket name.

model/trace/messaging.yaml

@@ -87,7 +87,7 @@ groups:
         note: >
           Semantic conventions for individual messaging systems SHOULD document whether `network.peer.*` attributes are applicable.
 
-          Network peer address and port are important when the application interacts with individual intermediary nodes directly
+          Network peer address and port are important when the application interacts with individual intermediary nodes directly,
 
           If a messaging operation involved multiple network calls (for example retries), the address of the last contacted node SHOULD be used.
       - ref: network.peer.port
@@ -102,11 +102,9 @@ groups:
       - ref: network.peer.address
         requirement_level: recommended
         note: >
-          If a database operation involved multiple network calls (for example retries), the address of the last contacted node SHOULD be used.
-        tag: tech-specific
+          If an operation involved multiple network calls (for example retries), the address of the last contacted node SHOULD be used.
       - ref: network.peer.port
         requirement_level: recommended
-        tag: tech-specific
 
   - id: messaging.rabbitmq
     type: attribute_group
@@ -123,9 +121,6 @@ groups:
           conditionally_required: When available.
         tag: tech-specific
       - ref: network.peer.address
-        note: >
-          If an operation involved multiple network calls (for example retries),
-          the address of the last contacted node SHOULD be used.
         tag: tech-specific
       - ref: network.peer.port
         tag: tech-specific
@@ -139,7 +134,7 @@ groups:
       - ref: messaging.destination.partition.id
         brief: >
           "String representation of the partition id the message  (or batch) is sent to or received from.""
-        tag: tech-specific-kafka
+        tag: tech-specific
       - ref: messaging.kafka.message.key
         tag: tech-specific
       - ref: messaging.kafka.consumer.group