Merge branch 'main' into 1372-vcs-metrics

open-telemetry · Nov 8, 2024 · 74363d8 · 74363d8
2 parents ae7d380 + afa2bf8
commit 74363d8
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/.github/workflows/changelog.yml b/.github/workflows/changelog.yml
@@ -76,13 +76,8 @@ jobs:
 
       # In order to validate any links in the yaml file, render the config to markdown
       - name: Render .chloggen changelog entries
-        run: make chlog-preview > changelog_preview.md
-      - name: Install markdown-link-check
-        run: npm install -g markdown-link-check
-      - name: Run markdown-link-check
         run: |
-          markdown-link-check \
-            --verbose \
-            --config .markdown_link_check_config.json \
-            changelog_preview.md \
-            || { echo "Check that anchor links are lowercase"; exit 1; }
+          make chlog-preview 2> changelog_preview.md
+          cat changelog_preview.md
+      - name: Run markdown-link-check
+        run: make markdown-link-check-changelog-preview
diff --git a/Makefile b/Makefile
@@ -69,6 +69,11 @@ markdown-link-check:
 			|| exit 1; \
 	done
 
+.PHONY: markdown-link-check-changelog-preview
+markdown-link-check-changelog-preview:
+	@if ! npm ls markdown-link-check; then npm install; fi
+	npx --no -- markdown-link-check --quiet --config .markdown_link_check_config.json changelog_preview.md;
+
 # This target runs markdown-toc on all files that contain
 # a comment <!-- tocstop -->.
 #