-
Notifications
You must be signed in to change notification settings - Fork 167
Context propagation requirements for messaging semantic conventions #205
Context propagation requirements for messaging semantic conventions #205
Conversation
text/trace/0205-messaging-semantic-conventions-context-propagation.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this makes sense to me!. I left a few minor things, mostly around wording and structure of text. Feel free to address them or not.
text/trace/0205-messaging-semantic-conventions-context-propagation.md
Outdated
Show resolved
Hide resolved
text/trace/0205-messaging-semantic-conventions-context-propagation.md
Outdated
Show resolved
Hide resolved
text/trace/0205-messaging-semantic-conventions-context-propagation.md
Outdated
Show resolved
Hide resolved
text/trace/0205-messaging-semantic-conventions-context-propagation.md
Outdated
Show resolved
Hide resolved
text/trace/0205-messaging-semantic-conventions-context-propagation.md
Outdated
Show resolved
Hide resolved
text/trace/0205-messaging-semantic-conventions-context-propagation.md
Outdated
Show resolved
Hide resolved
text/trace/0205-messaging-semantic-conventions-context-propagation.md
Outdated
Show resolved
Hide resolved
text/trace/0205-messaging-semantic-conventions-context-propagation.md
Outdated
Show resolved
Hide resolved
text/trace/0205-messaging-semantic-conventions-context-propagation.md
Outdated
Show resolved
Hide resolved
text/trace/0205-messaging-semantic-conventions-context-propagation.md
Outdated
Show resolved
Hide resolved
…tion.md Co-authored-by: Joao Grassi <joao@joaograssi.com>
…tion.md Co-authored-by: Joao Grassi <joao@joaograssi.com>
…tion.md Co-authored-by: Joao Grassi <joao@joaograssi.com>
…tion.md Co-authored-by: Joao Grassi <joao@joaograssi.com>
…tion.md Co-authored-by: Joao Grassi <joao@joaograssi.com>
…tion.md Co-authored-by: Joao Grassi <joao@joaograssi.com>
…tion.md Co-authored-by: Joao Grassi <joao@joaograssi.com>
…tion.md Co-authored-by: Joao Grassi <joao@joaograssi.com>
…tion.md Co-authored-by: Joao Grassi <joao@joaograssi.com>
…tion.md Co-authored-by: Joao Grassi <joao@joaograssi.com>
…tion.md Co-authored-by: Joao Grassi <joao@joaograssi.com>
…tion.md Co-authored-by: Joao Grassi <joao@joaograssi.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you Johannes
text/trace/0205-messaging-semantic-conventions-context-propagation.md
Outdated
Show resolved
Hide resolved
text/trace/0205-messaging-semantic-conventions-context-propagation.md
Outdated
Show resolved
Hide resolved
text/trace/0205-messaging-semantic-conventions-context-propagation.md
Outdated
Show resolved
Hide resolved
…tion.md Co-authored-by: Duane Pauls <duane.pauls@solace.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for putting this OTEP together. This is an accurate representation of the model put together by the Messaging SIG.
There's agreement from the working group itself, please review @open-telemetry/specs-approvers cc @yurishkuro |
@open-telemetry/specs-approvers Please review. As previously mentioned, the messaging working group approved this OTEP already, we only need one more Spec approval. |
This PR is a result of discussions in the messaging workgroup and has been split off #192 for easier review.
The existing messaging semantic conventions for tracing implicitly impose certain requirements on context propagation mechanisms used: while context is usually propagated on a per-request basis, the messaging semantic conventions assume that context is propagated on a per-message basis.
This OTEP proposes an addition to the existing messaging semantic conventions to make this requirement explicit. This is very important for reasoning about design questions regarding trace and span structure. Furthermore, explicating those requirements is of crucial importance for coming up with standardized context propagation mechanisms for messaging protocols. Some drafts for such standardization exist (AMQP, MQTT, CloudEvents), and the changes in this PR should help to verify those drafts against the requirements of OpenTelemetry semantic conventions.
The addition proposed in this document does not break or invalidate any of the existing semantic conventions for messaging, but rather makes an implicit requirement explicit.