Skip to content
This repository has been archived by the owner on Dec 6, 2024. It is now read-only.

Context propagation requirements for messaging semantic conventions #205

Merged
merged 24 commits into from
Jul 9, 2022

Conversation

pyohannes
Copy link
Contributor

This PR is a result of discussions in the messaging workgroup and has been split off #192 for easier review.

The existing messaging semantic conventions for tracing implicitly impose certain requirements on context propagation mechanisms used: while context is usually propagated on a per-request basis, the messaging semantic conventions assume that context is propagated on a per-message basis.

This OTEP proposes an addition to the existing messaging semantic conventions to make this requirement explicit. This is very important for reasoning about design questions regarding trace and span structure. Furthermore, explicating those requirements is of crucial importance for coming up with standardized context propagation mechanisms for messaging protocols. Some drafts for such standardization exist (AMQP, MQTT, CloudEvents), and the changes in this PR should help to verify those drafts against the requirements of OpenTelemetry semantic conventions.

The addition proposed in this document does not break or invalidate any of the existing semantic conventions for messaging, but rather makes an implicit requirement explicit.

@pyohannes pyohannes requested review from a team June 2, 2022 14:38
Copy link
Member

@joaopgrassi joaopgrassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this makes sense to me!. I left a few minor things, mostly around wording and structure of text. Feel free to address them or not.

pyohannes and others added 18 commits June 3, 2022 14:22
…tion.md

Co-authored-by: Joao Grassi <joao@joaograssi.com>
…tion.md

Co-authored-by: Joao Grassi <joao@joaograssi.com>
…tion.md

Co-authored-by: Joao Grassi <joao@joaograssi.com>
…tion.md

Co-authored-by: Joao Grassi <joao@joaograssi.com>
…tion.md

Co-authored-by: Joao Grassi <joao@joaograssi.com>
…tion.md

Co-authored-by: Joao Grassi <joao@joaograssi.com>
…tion.md

Co-authored-by: Joao Grassi <joao@joaograssi.com>
…tion.md

Co-authored-by: Joao Grassi <joao@joaograssi.com>
…tion.md

Co-authored-by: Joao Grassi <joao@joaograssi.com>
…tion.md

Co-authored-by: Joao Grassi <joao@joaograssi.com>
…tion.md

Co-authored-by: Joao Grassi <joao@joaograssi.com>
…tion.md

Co-authored-by: Joao Grassi <joao@joaograssi.com>
Copy link
Member

@blumamir blumamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you Johannes

pyohannes and others added 2 commits June 16, 2022 11:35
…tion.md

Co-authored-by: Duane Pauls <duane.pauls@solace.com>
Copy link

@tedsuo tedsuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for putting this OTEP together. This is an accurate representation of the model put together by the Messaging SIG.

@carlosalberto
Copy link
Contributor

There's agreement from the working group itself, please review @open-telemetry/specs-approvers

cc @yurishkuro

@carlosalberto
Copy link
Contributor

@open-telemetry/specs-approvers Please review. As previously mentioned, the messaging working group approved this OTEP already, we only need one more Spec approval.

@jmacd jmacd merged commit 6bc0cc3 into open-telemetry:main Jul 9, 2022
carlosalberto pushed a commit to open-telemetry/opentelemetry-specification that referenced this pull request Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

9 participants