Synchronize the upstream/downstream batch processor code #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
requested review from
lquerel,
moh-osman3 and
codeboten
as code owners
moh-osman3
approved these changes
Sep 24, 2024
Merged
jmacd
added a commit
that referenced
this pull request
Sep 26, 2024
- Concurrent batch processor: concurrency limit for legacy behavior or otherwise. [#254](#254) - Concurrent batch processor: EarlyReturn legacy compat feature. [#253](#253) - Concurrent batch processor: Synchronize with upstream; removes in-flight bytes metric, removes panic recovery as unnecessary divergence. [#251](#251) - Update collector dependencies to v0.110.0/v1.16.0; remove validation connector [#252](#252)
jmacd
added a commit
that referenced
this pull request
Oct 1, 2024
) This tests and fixes a deadlock in the concurrent batch processor, one that was especially easy to see with EarlyReturn=true, however exists either way. The bug was introduced in #251 when it removed a `defer func()` from `consumeAndWait()` by mistake. This is now covered by testing. This is fixed w/o a `defer func() { ... }`. The older code was both counting responses and updating a semaphore. Now that we only count responses and do not update a semaphore, there is no need to defer. The batcher will avoid sending to the waiter when the waiter's context is canceled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I prepare to submit the concurrent batch processor code to the upstream repository, I have developed the following proof-of-concept:
https://github.com/open-telemetry/opentelemetry-collector/pull/11248/files
I simplified, commented, linted, and tidied the code in that repository, aiming to achieve the smallest diff possible w/ only the essential features of this repository contributed back. This incorporates upstream changes in metadata.yaml, metrics code generation, and related lint improvements. Then, I copied the changed files back here.
No functional changes. I have eliminated the in-flight bytes metric and the panic recovery feature, both nice-to-have but complicates the diff and appear unnecessary.
Includes the upstream README.md, metadata.yaml, and generated code.