Skip to content
This repository has been archived by the owner on Nov 7, 2023. It is now read-only.

Avoid duplicate metadata in OTLP-Arrow receiver #39

Merged
merged 2 commits into from
Jan 20, 2023

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Jan 19, 2023

In cases where both stream context and request-context define the same key.
This works around a problem caused by the way the headersetter_extension works combined with the problem that is discussed in open-telemetry/opentelemetry-collector#6965.

Part of #33.

@jmacd jmacd requested a review from lquerel January 19, 2023 23:46
@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Base: 90.85% // Head: 90.85% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (fcfc1d6) compared to base (3111888).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #39   +/-   ##
=======================================
  Coverage   90.85%   90.85%           
=======================================
  Files         243      243           
  Lines       14987    14999   +12     
=======================================
+ Hits        13616    13628   +12     
  Misses       1099     1099           
  Partials      272      272           
Impacted Files Coverage Δ
receiver/otlpreceiver/internal/arrow/arrow.go 88.60% <100.00%> (+0.93%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment

receiver/otlpreceiver/internal/arrow/arrow.go Show resolved Hide resolved
@jmacd jmacd merged commit 9017ad2 into open-telemetry:main Jan 20, 2023
@jmacd jmacd deleted the jmacd/header_dedup branch January 20, 2023 18:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants