Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18n] Google translate button in fallback pages for all locales #6117

Merged
merged 2 commits into from
Jan 30, 2025
Merged

[i18n] Google translate button in fallback pages for all locales #6117

merged 2 commits into from
Jan 30, 2025

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jan 30, 2025 •
edited
Loading

  • Contributes to Improved i18n support #4467
  • Adds a Google-translate button to the top of English fallback pages (and only fallback pages). After choosing your own locale language, GT will automatically translate all fallback pages when you visit them. The feature allows you to toggle between viewing the original and toggling translation.
  • The goal here is not to replace manual translations, but to offer an improved user experience for those navigating the site in a particular locale. Google translate isn't perfect, but it can be "good enough". Also it can be a point of comparison for translator.

Preview: https://deploy-preview-6117--opentelemetry.netlify.app/fr/docs/

Screenshot

Here's an example of the /fr/docs English fallback page translated by Google:

image

@chalin chalin added enhancement New feature or request i18n internationalization labels Jan 30, 2025
@chalin chalin requested a review from a team as a code owner January 30, 2025 12:04
@chalin chalin changed the title [i18n] Translate en fallback pages for all locals [i18n] Translate en fallback pages for all locales Jan 30, 2025
@chalin chalin force-pushed the chalin-im-translate-fallback-pages-2025-01-29 branch from 7a886ca to b9fc010 Compare January 30, 2025 12:18
@chalin chalin changed the title [i18n] Translate en fallback pages for all locales [i18n] Google translate of en fallback pages for all locales Jan 30, 2025
@chalin chalin force-pushed the chalin-im-translate-fallback-pages-2025-01-29 branch from b9fc010 to aac10fc Compare January 30, 2025 12:37
@chalin chalin changed the title [i18n] Google translate of en fallback pages for all locales [i18n] Google translate button in fallback pages for all locales Jan 30, 2025
@chalin chalin added this pull request to the merge queue Jan 30, 2025
@chalin chalin mentioned this pull request Jan 30, 2025
Open
42 tasks
Merged via the queue into open-telemetry:main with commit 3652f28 Jan 30, 2025
17 checks passed
@chalin chalin deleted the chalin-im-translate-fallback-pages-2025-01-29 branch January 30, 2025 14:09
Vinaum8 pushed a commit to Vinaum8/opentelemetry.io that referenced this pull request Jan 30, 2025
@chalin @Vinaum8
[i18n] Google translate button in fallback pages for all locales (ope…
94cd759 
…n-telemetry#6117)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svrnm svrnm svrnm approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request i18n internationalization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chalin @svrnm