Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] Support automatic banner management across localizations #4625

Merged
merged 11 commits into from
Jun 7, 2024

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jun 7, 2024

Preview:

Screenshot

image
image

@chalin chalin added CI/infra CI & infrastructure i18n internationalization labels Jun 7, 2024
@chalin chalin requested review from a team June 7, 2024 16:45
@chalin chalin added the lang:ja label Jun 7, 2024
@chalin chalin requested a review from ymotongpoo June 7, 2024 16:57
@chalin
Copy link
Contributor Author

chalin commented Jun 7, 2024

There's an issue which running scripts/i18n-check.sh -u in a GH action because apparently it doesn't have access to all the branches, or the expected branch, etc. I don't want to hold up this PR. I'll debug that separately.

@open-telemetry/docs-zh-approvers and @ymotongpoo: I'll assume that you are ok with the translations here for the OTel Community day. If not we can address the required changes in a followup PR.

@chalin
Copy link
Contributor Author

chalin commented Jun 7, 2024

All green, merging.

@chalin chalin merged commit 8603bc8 into open-telemetry:main Jun 7, 2024
16 checks passed
@chalin chalin deleted the chalin-im-i18n-banner-2024-06-07 branch June 7, 2024 17:37
@ymotongpoo
Copy link
Contributor

@chalin thanks! I checked Japanese translation for OTel community day banner and it looks perfect!

@chalin
Copy link
Contributor Author

chalin commented Jun 7, 2024

@ymotongpoo - thank you for confirming ✨

ymotongpoo pushed a commit to ymotongpoo/opentelemetry.io that referenced this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure i18n internationalization lang:ja lang:zh
Projects
None yet
3 participants