Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional details to the Instrumentation guide #3309

Merged
merged 18 commits into from
Oct 4, 2023

Conversation

estolfo
Copy link
Contributor

@estolfo estolfo commented Sep 25, 2023

Having had the experience of instrumenting the Elasticsearch Ruby, .NET, and Java clients natively with OpenTelemetry, we're proposing some additional details to the instrumentation guide.

Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, those are some really valuable suggestions, I provided some feedback, please take a look

content/en/docs/concepts/instrumentation/libraries.md Outdated Show resolved Hide resolved
content/en/docs/concepts/instrumentation/libraries.md Outdated Show resolved Hide resolved
content/en/docs/concepts/instrumentation/libraries.md Outdated Show resolved Hide resolved
content/en/docs/concepts/instrumentation/libraries.md Outdated Show resolved Hide resolved
content/en/docs/concepts/instrumentation/libraries.md Outdated Show resolved Hide resolved
content/en/docs/concepts/instrumentation/libraries.md Outdated Show resolved Hide resolved
@estolfo estolfo force-pushed the instrumentation-guide branch from e8d4ad2 to de9e7aa Compare October 2, 2023 09:23
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @estolfo, lgtm (contentwise), let us know if you need some help with fixing the workflow issues

@svrnm svrnm merged commit e5d6aea into open-telemetry:main Oct 4, 2023
@svrnm
Copy link
Member

svrnm commented Oct 4, 2023

thank you for your contribution @estolfo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants