Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update semantic-conventions #2982

Merged
merged 11 commits into from
Jul 7, 2023

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jul 6, 2023

IMPORTANT NOTE: if this PR is merged, then the semantic-conventions will be published to the production server. Are y'all ok with that @jsuereth @joaopgrassi @open-telemetry/specs-semconv-approvers?

Preview: https://deploy-preview-2982--opentelemetry.netlify.app/docs/specs/semconv/

@chalin chalin requested review from a team, joaopgrassi and jsuereth July 6, 2023 21:53
@chalin
Copy link
Contributor Author

chalin commented Jul 6, 2023

FYI, I'm working on fixing links. Wanted to get the preview out ASAP.

@jsuereth
Copy link

jsuereth commented Jul 6, 2023

If it helps, I had a few of my own link fixed here: https://github.com/jsuereth/opentelemetry.io/pull/new/wip-bump-semconv

@chalin chalin marked this pull request as draft July 6, 2023 22:12
@chalin chalin force-pushed the chalin-im-semconv-2023-07-06 branch from 24961a6 to 9fdd3d9 Compare July 6, 2023 22:13
@chalin
Copy link
Contributor Author

chalin commented Jul 6, 2023

If it helps, I had a few of my own link fixed here: https://github.com/jsuereth/opentelemetry.io/pull/new/wip-bump-semconv

All done, thanks!

@chalin chalin marked this pull request as ready for review July 6, 2023 22:14
@chalin
Copy link
Contributor Author

chalin commented Jul 6, 2023

Oh cool, you actually added custom frontmatter @jsuereth! Ok, let me use that too!

@chalin
Copy link
Contributor Author

chalin commented Jul 6, 2023

There will be followup PRs, but this is ready to go @jsuereth.
Do we need any more approvals, or can this be merged?

@chalin
Copy link
Contributor Author

chalin commented Jul 6, 2023

@jsuereth - if you agree to this being merged, please acknowledge that you've read the IMPORTANT NOTE in the opening comment, and agree with the semconv pages being published.

Copy link
Member

@joaopgrassi joaopgrassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving my approval on the general website structure for the semconv. Looks really nice!

@jsuereth
Copy link

jsuereth commented Jul 7, 2023

@chalin I'd like to actually only publish a stable tag to the website if we can (and make sure the website shows that stable version). Is there more work required to do that?

Given how the website looks with this PR though, I'm comfortable removing this as a blocker for releasing the semconv repository and then we can update this to pull in that known version.

Copy link

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also wanted to comment, if you'd like to publish this now and add in a version as soon as we have our first release, I'm also ok with that timing.

@chalin chalin force-pushed the chalin-im-semconv-2023-07-06 branch from 9409d48 to 95635ea Compare July 7, 2023 12:37
@chalin
Copy link
Contributor Author

chalin commented Jul 7, 2023

@chalin I'd like to actually only publish a stable tag ...

@jsuereth - Ok, here's what I've done: I've kept the draft status for the semconv pages. That means that they won't appear on the production server yet. That'll give us time to address the issues I've raised over the semconv repo.

Once the build is green, since this PR has your and other approvals, I'll merge.

@chalin chalin marked this pull request as ready for review July 7, 2023 12:40
@chalin chalin changed the title Publish semantic-conventions Update semantic-conventions Jul 7, 2023
@chalin chalin merged commit d7abb54 into open-telemetry:main Jul 7, 2023
@chalin chalin deleted the chalin-im-semconv-2023-07-06 branch July 7, 2023 12:41
@jsuereth
Copy link

jsuereth commented Jul 7, 2023

Thanks for all the hard work @chalin ! This is really looking great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants