Fixes #2907 - Schema files are served from semantic-conventions. #2908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuereth
force-pushed
the
wip-semconv-migration
branch
from
2bb8d30
to
e5b8d5c
Compare
chalin
force-pushed
the
wip-semconv-migration
branch
2 times, most recently
from
e5547e8
to
24480a8
Compare
This was referenced Jun 27, 2023
…clude version in the semconv repository pulled in.
chalin
force-pushed
the
wip-semconv-migration
branch
from
24480a8
to
a65bb57
Compare
chalin
reviewed
Jun 27, 2023
| @@ -15,7 +15,7 @@ cp -R $SRC/* $DEST/ | |||
| find $DEST/ -name "README.md" -exec sh -c 'f="{}"; mv -- "$f" "${f%README.md}_index.md"' \; | |||
|
|
|||
| # To exclude a file use, e.g.: -not -path '*/specification/_index.md' | |||
| FILES=$(find $DEST -name "*.md") | |||
| FILES=$(find $DEST -name "*.md" -not -path '*/specification/*/semantic_conventions/*') | |||
There was a problem hiding this comment.
We won't want to exclude anything from the OTel spec because that is likely to break things. Whatever the OTel spec repo decides to do with the semconv pages, we'll publish as is on the repo. For example, OTLP placeholder pages were left in the OTel spec after the move to the OTLP repo.
|
FYI, I rebased after the merge of #2918. |
|
Closing in favor of @chalin's PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd like to move schema files to be served from the semantic-conventions repository. This is the first step, next we'd like to add an OpenTelemetry-Bot action that will bump the content module every time semantic conventions cuts a release.
DO NOT MERGE: This would make the
1.21.0schema available immediately.This PR is for review, to make sure this is the right approach for publishing schema files into the website going forward.
TODOS
specification/semantic_conventions/*.mdfrom being pulled in OpenTelemetry specification.