Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semconv pages: don't warn about external links to spec #2785

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented May 24, 2023

Concretely, this eliminates the following warnings (which are no longer relevant because the pages have moved):

WARNING: link to spec page encoded as an external URL, but should be a local path, fix this upstream;
  File: /Users/chalin/git/lf/open-telemetry/opentelemetry.io/tmp/otel/specification/metrics/semantic_conventions/http-metrics.md 
  Link: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/api.md#instrument-advice
WARNING: link to spec page encoded as an external URL, but should be a local path, fix this upstream;
  File: /Users/chalin/git/lf/open-telemetry/opentelemetry.io/tmp/otel/specification/metrics/semantic_conventions/http-metrics.md 
  Link: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/api.md#instrument-advice

@chalin chalin added the CI/infra CI & infrastructure label May 24, 2023
@chalin chalin requested a review from a team May 24, 2023 13:54
@chalin chalin merged commit e117688 into open-telemetry:main May 24, 2023
@chalin chalin deleted the chalin-im-semconv-no-warn-2023-05-24 branch May 24, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants