Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add collector section to .NET getting started #1326

Merged
merged 8 commits into from
May 24, 2022
Merged

Add collector section to .NET getting started #1326

merged 8 commits into from
May 24, 2022

Conversation

cartermp
Copy link
Contributor

@cartermp cartermp commented May 1, 2022 •
edited
Loading

@cartermp cartermp requested a review from a team May 1, 2022 16:03
chalin
chalin reviewed May 17, 2022
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this addition @cartermp. See inline comments.

content/en/docs/instrumentation/net/getting-started.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/net/getting-started.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/net/getting-started.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/net/getting-started.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/net/getting-started.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/net/getting-started.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/net/getting-started.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/net/getting-started.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/net/getting-started.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/net/getting-started.md Outdated Show resolved Hide resolved
@chalin chalin self-assigned this May 17, 2022
@cartermp cartermp requested review from a team May 20, 2022 06:50
chalin
chalin approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after comments have been addressed. Thanks!

content/en/docs/instrumentation/net/getting-started.md Outdated Show resolved Hide resolved
@cartermp
Copy link
Contributor Author

Okay, should be all addressed.

@cartermp @alanwest
Apply suggestions from code review
7e799e9 
Co-authored-by: Alan West <3676547+alanwest@users.noreply.github.com>
pjanotti
pjanotti approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@pjanotti pjanotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ a nit.

content/en/docs/instrumentation/net/getting-started.md Outdated Show resolved Hide resolved
@mtwo mtwo merged commit 764fc0f into open-telemetry:main May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtwo mtwo mtwo approved these changes

@alanwest alanwest alanwest approved these changes

@chalin chalin chalin approved these changes

@cijothomas cijothomas cijothomas approved these changes

@pjanotti pjanotti pjanotti approved these changes

@Kielek Kielek Kielek approved these changes

@reyang reyang reyang approved these changes

Assignees

@chalin chalin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cartermp @mtwo @alanwest @chalin @cijothomas @pjanotti @Kielek @reyang