Exposes OpenTelemetryConcurrency target #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeedleInAJayStack
requested review from
nachoBonafonte,
bryce-b and
vvydier
as code owners
bryce-b
approved these changes
Aug 20, 2024
|
Hmm, kinda strange that the Linux CI appears to be stuck. I'm able to successfully run these tests on a swift:5.10 docker image locally. Any ideas? |
|
It may just be an intermittent failure, I had quite a few when working on the original PR. There were also a couple of issues with tests never finishing on Linux even when they worked fine on other platforms. I fixed those issues that I encountered but it's possible another one has popped up now. |
|
Hi @NeedleInAJayStack the concurrency target should be its own product. Adding it to the OpenTelemetryApi product would create a circular dependency. |
nachoBonafonte
requested changes
Aug 22, 2024
NeedleInAJayStack
force-pushed
the
feat/expose-concurrency
branch
from
ce93f21
to
25057d3
Compare
|
Sure, I've adjusted it to be a separate product. Thanks! |
bryce-b
approved these changes
Aug 26, 2024
|
@nachoBonafonte Just a gentle reminder on this PR - any thoughts on my changes? Thanks! |
nachoBonafonte
approved these changes
Aug 29, 2024
nachoBonafonte
added a commit
to nachoBonafonte/opentelemetry-swift
that referenced
this pull request
Aug 29, 2024
* main: Exposes OpenTelemetryConcurrency target (open-telemetry#592) # Conflicts: # Package@swift-5.9.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you @semicoleon for the excellent changes in #546! This MR simply exposes the new
OpenTelemetryConcurrencytarget through theOpenTelemetryApiproduct so that it is available for usage by downstream packages. This enables usage as shown in/Examples/ConcurrencyContext/main.swift.If you'd prefer for
OpenTelemetryConcurrencyto get its own product, just let me know and I'm happy to adjust. Thanks!