Move http to main spec #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielkhan
requested review from
AloisReitbauer,
bogdandrutu,
c24t,
carlosalberto,
iredelmeier,
SergeyKanzhelev,
songy23,
tedsuo and
yurishkuro
as code owners
Co-Authored-By: Sergey Kanzhelev <S.Kanzhelev@live.com>
SergeyKanzhelev
suggested changes
Jun 10, 2019
Co-Authored-By: Sergey Kanzhelev <S.Kanzhelev@live.com>
SergeyKanzhelev
approved these changes
Jun 11, 2019
reyang
reviewed
Jun 11, 2019
reyang
reviewed
Jun 11, 2019
reyang
reviewed
Jun 11, 2019
Co-Authored-By: Sergey Kanzhelev <S.Kanzhelev@live.com>
SergeyKanzhelev
approved these changes
Jun 12, 2019
reyang
approved these changes
Jun 12, 2019
yurishkuro
reviewed
Sep 28, 2019
| For a HTTP client span, `SpanKind` MUST be `Client`. | ||
|
|
||
| Given an [RFC 3986](https://www.ietf.org/rfc/rfc3986.txt) compliant URI of the form | ||
| `scheme:[//authority]path[?query][#fragment]`, the span name of the span SHOULD |
There was a problem hiding this comment.
-1
in OpenTracing we always explicitly recommended against doing that. In the REST services it is very common to have entity IDs as part of the path, e.g. /api/user/{uuid}. And since the instrumentation in general has no knowledge of whether the application's URL pattern includes entity IDs, recommending path as span name can easily lead to cardinality explosion.
SergeyKanzhelev
pushed a commit
to SergeyKanzhelev/opentelemetry-specification
that referenced
this pull request
Feb 18, 2020
* Moved HTTP Client to semantic conventions * Moved HTTP server * Update semantic-conventions.md Co-Authored-By: Sergey Kanzhelev <S.Kanzhelev@live.com> * Simplified attribute names. * Added note on using lower cardinality names if a framework can infer them. * Update semantic-conventions.md Co-Authored-By: Sergey Kanzhelev <S.Kanzhelev@live.com> * Cahnge status to status_code * Add component * Update semantic-conventions.md Co-Authored-By: Sergey Kanzhelev <S.Kanzhelev@live.com> * Added optional status_text attribute * Removed attributes covered in the main spec from OC and OT work in progress files.
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 21, 2024
Signed-off-by: Bogdan Cristian Drutu <bogdandrutu@gmail.com>
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 23, 2024
Signed-off-by: Bogdan Cristian Drutu <bogdandrutu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #24