Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework metric signal overview #3916

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Rework metric signal overview #3916

merged 2 commits into from
Mar 5, 2024

Conversation

jaydeluca
Copy link
Member

@jaydeluca jaydeluca commented Feb 29, 2024 •
edited
Loading

Continuing #3900

Changes

The Metric signal overview was outdated, referencing classes that no longer exist.

  • Added overview of Meter instruments
  • Added section about views
  • Updated wording / descriptions

@jaydeluca jaydeluca requested review from a team February 29, 2024 12:07
@jaydeluca jaydeluca mentioned this pull request Feb 29, 2024
Closed
@arminru arminru requested a review from reyang March 5, 2024 12:53
jsuereth
jsuereth approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice cleanup. Thanks for taking the work to make this more understandable!

reyang
reyang approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the PR as I already reviewed it in #3900.

@reyang reyang merged commit 3cfd5ad into open-telemetry:main Mar 5, 2024
7 checks passed
@jaydeluca jaydeluca mentioned this pull request Jul 1, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsuereth jsuereth jsuereth approved these changes

@reyang reyang reyang approved these changes

Assignees

@jsuereth jsuereth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaydeluca @jsuereth @reyang