Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus SDK exporter specification cleanups #3872

Merged
merged 4 commits into from
Mar 27, 2024
Merged

Prometheus SDK exporter specification cleanups #3872

merged 4 commits into from
Mar 27, 2024
+46 −25

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Feb 8, 2024 •
edited
Loading

Fixes #3702
Fixes #2468

Addresses #3737 (comment)

Changes

  • Add option to disable target info metric.
  • Move SDK-specific language from the compatibility spec to the prometheus exporter spec.
  • Disallow using OpenMetrics proto format, or Prometheus remote write formats in SDK exporters
  • Recommend using Prometheus client libraries
  • Clarify that only features supported by the text format are required to be implemented by Prometheus exporters
  • Require prometheus SDK exporters to follow the compatibility specification.

@open-telemetry/wg-prometheus

@dashpole dashpole requested review from a team February 8, 2024 22:03
@dashpole dashpole mentioned this pull request Feb 8, 2024
Open
@dashpole dashpole force-pushed the clarify_prometheus_timestamps branch from d41838b to 716c3af Compare February 9, 2024 14:41
@github-actions GitHub Actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 22, 2024
@dashpole dashpole force-pushed the clarify_prometheus_timestamps branch from f8f11b1 to 1331d33 Compare February 22, 2024 19:15
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Mar 7, 2024
@dashpole
Copy link
Contributor Author

dashpole commented Mar 7, 2024

This is still relevant.

@MrAlias MrAlias reopened this Mar 7, 2024
@MrAlias MrAlias removed the Stale label Mar 7, 2024
@dashpole dashpole force-pushed the clarify_prometheus_timestamps branch from 1331d33 to 45c2ae0 Compare March 14, 2024 15:24
@carlosalberto
Copy link
Contributor

Sorry for the delay @dashpole - I think we are mostly ready to merge this one.

Can we include the Add option to disable target info metric. bit in the CHANGELOG? Otherwise it looks this was only an editorial change.

@dashpole dashpole force-pushed the clarify_prometheus_timestamps branch from 50b7221 to b438bcd Compare March 25, 2024 20:01
@dashpole
Copy link
Contributor Author

@carlosalberto added

@carlosalberto carlosalberto merged commit 98e1344 into open-telemetry:main Mar 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cijothomas cijothomas cijothomas left review comments

@carlosalberto carlosalberto carlosalberto approved these changes

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@jmacd jmacd jmacd approved these changes

@MrAlias MrAlias MrAlias approved these changes

Assignees

@carlosalberto carlosalberto

Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@dashpole @carlosalberto @Aneurysm9 @jmacd @cijothomas @MrAlias