Prometheus compatibility: represent Prometheus Info, StateSet and Unknown-typed metrics in OTLP #3868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
changed the title
dashpole
force-pushed
the
prometheus_type_metadata
branch
from
fa7a69f to
b22dd04
Compare
jsuereth
approved these changes
Feb 7, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
jack-berg
approved these changes
Feb 16, 2024
dashpole
force-pushed
the
prometheus_type_metadata
branch
2 times, most recently
from
69e93df to
2697ad1
Compare
…nown-typed metrics in OTLP
dashpole
force-pushed
the
prometheus_type_metadata
branch
from
5b26ba5 to
f32b0dd
Compare
MrAlias
approved these changes
Feb 22, 2024
pellared
approved these changes
Feb 28, 2024
Aneurysm9
approved these changes
Feb 29, 2024
|
Should this be included in March's release? |
|
@carlosalberto I would appreciate that. The only caveat is that the proto changes this is based on haven't been released yet, so this can't actually be implemented yet |
|
Aha! yes, I had forgotten about the proto not releasing yet the related update. WDYT @jsuereth ? |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
@carlosalberto I think we need to release the proto directory.... |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Merged
|
Merging as proto 1.2.0 with |
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
…nown-typed metrics in OTLP (open-telemetry#3868) Fixes open-telemetry#3058 Fixes open-telemetry#1712 Fixes open-telemetry#2409 ## Changes Use metric.metadata (added in open-telemetry/opentelemetry-proto#514) to support representing prometheus metric types in OTLP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3058
Fixes #1712
Fixes #2409
Changes
Use metric.metadata (added in open-telemetry/opentelemetry-proto#514) to support representing prometheus metric types in OTLP.
Alternative Considered
We could consider using a metadata key that is not prometheus specific (e.g.
gauge.subtype=unknown), but a prometheus-specific key seems better for avoiding collisions with other uses.CHANGELOG.mdfile updated for non-trivial changesspec-compliance-matrix.mdupdated if necessary@open-telemetry/wg-prometheus