add namespace to jvm metric attributes #3464
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertysentry
reviewed
May 2, 2023
- which is in the spirit of other attributes such as "net.peer.ip", where "." is used multiple times
- which provides a common prefix ("memory.") with "memory.type" to establish a logical grouping
|
@zeitlinger can you add the schema transformations to this PR also? check out https://github.com/open-telemetry/opentelemetry-specification/pull/3431/files |
- which is in the spirit of other attributes such as "net.peer.ip", where "." is used multiple times
- which provides a common prefix ("memory.") with "memory.type" to establish a logical grouping
done 😄 |
|
@zeitlinger heads up - most likely this PR will be closed, and we'll ask you to resubmit the PR in a new repo, please refer to #3474 (comment). |
jsuereth
requested changes
May 12, 2023
There was a problem hiding this comment.
Please move this to https://github.com/open-telemetry/semantic-conventions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3417
Changes
I'll create the changelog and schema changes after #3431 has been merged (to avoid merge conflicts)