Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove schema transformations from the concept of telemetry stability for now #3372

Closed

Conversation

trask
Copy link
Member

@trask trask commented Apr 6, 2023

Fixes #3296
Fixes #2606

Changes

Prepares versioning-and-stability.md and telemetry-stability.md documents to be marked Stable themselves, by removing schema transformations from the concept of telemetry stability for now.

Note: I wasn't quite sure where to move the pieces that I removed, definitely open to feedback.

@trask trask force-pushed the schema-translations-are-experimental branch from ae7a564 to 94016d4 Compare April 6, 2023 02:23
@trask trask marked this pull request as ready for review April 6, 2023 02:24
@trask trask requested review from a team April 6, 2023 02:24
@lmolkova
Copy link
Contributor

lmolkova commented Apr 6, 2023

Also fixes #2606

Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
@arminru arminru added area:semantic-conventions Related to semantic conventions spec:miscellaneous For issues that don't match any other spec label labels Apr 6, 2023
@tigrannajaryan
Copy link
Member

Prepares versioning-and-stability.md and telemetry-stability.md documents to be marked Stable themselves, by removing schema transformations from the concept of telemetry stability for now.

Note: I wasn't quite sure where to move the pieces that I removed, definitely open to feedback.

Why remove instead of marking the individual sections as "Experimental"?

Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking since I don't think we need to delete the text when we can instead mark the section "Experimental".

Happy to unblock this if we think the sections are wrong and do need to be removed, but that is not what the PR description says at the moment. In the past our approach about useful but not yet ready to make "Stable" sections of the spec was to label section stability individually.

@trask
Copy link
Member Author

trask commented Apr 6, 2023

Why remove instead of marking the individual sections as "Experimental"?

some of the language was embedded into sections which we would otherwise want to mark stable

I will try to re-work the PR in a way that pulls that language out into separate sections instead of deleting

though let's resolve the new discussions going on in #3296 first, as that may affect the breakout as well

@trask
Copy link
Member Author

trask commented Apr 11, 2023

closing in favor of #3380

@trask trask closed this Apr 11, 2023
@trask trask deleted the schema-translations-are-experimental branch April 11, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions spec:miscellaneous For issues that don't match any other spec label
Projects
None yet
6 participants