-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Declare OTLP stable #3274
Declare OTLP stable #3274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should move the "Stable" tag from individual sections?
Can you also remove the "status" callouts in subsections since the whole document is marked stable? |
b9b7770
to
24af291
Compare
👍🏼 I also removed the signal maturity level section. |
24af291
to
f001eee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking this changes as, I think, there are some last conditions before we can declare OTLP stable as a whole: open-telemetry/opentelemetry-proto#400
@tigrannajaryan would you mind taking a look? Discard this changes request otherwise.
@carlosalberto Might worth putting a line or two in OTLP spec about why it is not stable yet if all of its components are declared as stable. |
This should be fine, I don't see anything that remains experimental. Let's not rush it though and give us time to think through. A question: do we have sufficiently clear understanding of what "Stable" means for this document or we need to spell it out explicitly? |
Since OTLP/JSON was declared stable, all the parts of the OTLP spec is stable so the whole spec should be declared as such See open-telemetrygh-2930 Signed-off-by: Jonatan Ivanov <jonatan.ivanov@gmail.com>
f001eee
to
63abbc5
Compare
@tigrannajaryan Can you bring this up in the next spec meeting to see what others think? |
@jonatan-ivanov Oh, definitely. |
Since OTLP/JSON was declared stable, all the parts of the OTLP spec is stable so the whole spec should be declared as such
See gh-2930