Clarify SDK ReadableSpan's parent Context (fix accidentally requiring full parent chain) #3257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oberon00
commented
Feb 27, 2023
Oberon00
force-pushed
the
hasremoteparent
branch
from
81d8390
to
4f83da5
Compare
Oberon00
added
area:sdk
|
Please tell me if I should create a tracking issue for this |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
I think this would be a rather important clarification to align the spec with reality. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
It might be a boring PR but I still think it should not be ignored |
Oberon00
changed the title
Oberon00
changed the title
carlosalberto
approved these changes
Mar 20, 2023
|
I will mention this again tomorrow in the Spec call. Also, I will take a quick look at a few SIGs implementations to triple verify we are cool. |
jmacd
approved these changes
Mar 22, 2023
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Can this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves open-telemetry/oteps#182 (comment)
Changes
Clarify required parent information in ReadableSpan. Technically a relaxation, but previously it was easy to overlook certain properties were required.
Related OTEP: open-telemetry/oteps#182