-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added AWS S3 semantic conventions #3251
Conversation
@willarmiros , @arminru FYI |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
@open-telemetry/specs-approvers Can we get some review before this PR gets auto-closed? (Or extending it somehow?) Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on discussion, I think this seems fine to add AWS-specific requests for these, as I don't see uniformity is storage provider attributes here. I think from an o11y perspective, it's almost better for the AWS specific info to show up (as it would aide in using AWS to debug what happened on their end). I see needing similar attributes for Google's cloud storage solutions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, from Azure perspective, we'd want to provide similar attributes, but unifying them across cloud providers does not seem to improve user experience.
@open-telemetry/specs-approvers Could someone trigger / approve the CI, please? |
OK, I see it's related to #3327. Once that PR is merged, the CI for this PR should be green again. |
Fixes #3193
Changes
Adds S3 related attributes to the AWS SDK semantic conventions.
Related issues: