Use attribute_group for cross-signal HTTP attributes #3183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
force-pushed
the
http-attribute-groups
branch
from
a1421c7 to
939e470
Compare
|
it looks like the markdown-link-check doesn't understand |
trask
approved these changes
Feb 8, 2023
reyang
approved these changes
Feb 8, 2023
arminru
added
semconv:HTTP
area:semantic-conventions
jamesmoessis
reviewed
Feb 9, 2023
jamesmoessis
approved these changes
Feb 13, 2023
chalin
reviewed
Mar 6, 2023
Comment on lines
-249
to
+257
| SHOULD include the [application root](#http-server-definitions) if there is one. | ||
| SHOULD include the [application root](/specification/trace/semantic_conventions/http.md#http-server-definitions) if there is one. |
There was a problem hiding this comment.
Unless I'm missing something, ... why add an absolute path to an in-page target?
To me this is just confusing because it gives the impression that the target is in another page when it is not.
The same remark applied to the two other links to in-page targets below. IMHO, these changes should be reverted.
/cc @carlosalberto
Merged
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change refactors HTTP semconv in the following way:
semantic_conventions\http-common.yamlsemantic_conventions\trace\http.yamlsemantic_conventions\metrics\http.yamlRelated: #2666, #2001
It also uses new
attribute_groupsemconv type in a few places wherespanwas used incorrectlyThere are a couple of rough edges on tooling side - open-telemetry/build-tools#133. They are not blocking and can be resolved later.