Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove http.flavor in favor of net.app.protocol.* #3178

Closed
wants to merge 2 commits into from
Closed

Remove http.flavor in favor of net.app.protocol.* #3178

wants to merge 2 commits into from
+76 −93

Conversation

trask
Copy link
Member

@trask trask commented Feb 6, 2023 •
edited
Loading

Fixes #2626

Changes

Removes http.flavor and replaces it by the recently introduced net.app.protocol.name and net.app.protocol.version.

@trask trask marked this pull request as ready for review February 6, 2023 22:02
@trask trask requested review from a team February 6, 2023 22:02
@arminru arminru added semconv:HTTP spec:metrics Related to the specification/metrics directory spec:trace Related to the specification/trace directory area:semantic-conventions Related to semantic conventions labels Feb 7, 2023
@trask trask marked this pull request as draft February 9, 2023 00:15
@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 16, 2023
@Oberon00 Oberon00 mentioned this pull request Feb 16, 2023
Closed
@SergeyKanzhelev SergeyKanzhelev removed their assignment Feb 18, 2023
@github-actions
Copy link

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Feb 26, 2023
@trask trask deleted the remove-http-flavor branch October 14, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area:semantic-conventions Related to semantic conventions semconv:HTTP spec:metrics Related to the specification/metrics directory spec:trace Related to the specification/trace directory Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

http.flavor should become net.app.protocol.name and net.app.protocol.version
3 participants
@trask @arminru @SergeyKanzhelev