Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Fix wrong metric type in OTel to Prom compatibility section. #3107

Merged
merged 2 commits into from
Jan 17, 2023
Merged

[chore] Fix wrong metric type in OTel to Prom compatibility section. #3107

merged 2 commits into from
Jan 17, 2023

Conversation

kovrus
Copy link
Member

@kovrus kovrus commented Jan 17, 2023

Fix the wrong metric type in the OTel to Prometheus compatibility section.

@kovrus kovrus requested review from a team January 17, 2023 15:32
reyang
reyang approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@reyang reyang added the editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind. label Jan 17, 2023
@reyang
Copy link
Member

reyang commented Jan 17, 2023

@kovrus thanks for the catch!

@carlosalberto
Copy link
Contributor

cc @dashpole

dashpole
dashpole approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@reyang reyang closed this Jan 17, 2023
@reyang reyang reopened this Jan 17, 2023
@carlosalberto carlosalberto merged commit 2f386f8 into open-telemetry:main Jan 17, 2023
@kovrus kovrus deleted the fix-metric-type branch January 17, 2023 23:10
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
@kovrus
[chore] Fix wrong metric type in OTel to Prom compatibility section. (o…
c820079 
…pen-telemetry#3107)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

@MrAlias MrAlias MrAlias approved these changes

@dashpole dashpole dashpole approved these changes

Assignees

@carlosalberto carlosalberto

Labels
editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kovrus @reyang @carlosalberto @dashpole @MrAlias