Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[semantic conventions] add ibm cloud as a cloud provider #2965

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ release.

### Semantic Conventions

- Add IBM Cloud as a cloud provider.
([#2965](https://github.com/open-telemetry/opentelemetry-specification/pull/2965))

### Compatibility

### OpenTelemetry Protocol
Expand Down
7 changes: 7 additions & 0 deletions semantic_conventions/resource/cloud.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,13 @@ groups:
- id: 'gcp'
value: 'gcp'
brief: 'Google Cloud Platform'
- id: 'ibm_cloud'
value: 'ibm_cloud'
brief: 'IBM Cloud'
- id: 'tencent_cloud'
value: 'tencent_cloud'
brief: 'Tencent Cloud'

brief: >
Name of the cloud provider.
- id: account.id
Expand Down Expand Up @@ -110,6 +114,9 @@ groups:
- id: gcp_app_engine
value: 'gcp_app_engine'
brief: Google Cloud App Engine (GAE)
- id: ibm_cloud_openshift
value: 'ibm_cloud_openshift'
brief: Red Hat OpenShift on IBM Cloud
- id: tencent_cloud_cvm
value: 'tencent_cloud_cvm'
brief: Tencent Cloud Cloud Virtual Machine (CVM)
Expand Down
2 changes: 2 additions & 0 deletions specification/resource/semantic_conventions/cloud.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
| `aws` | Amazon Web Services |
| `azure` | Microsoft Azure |
| `gcp` | Google Cloud Platform |
| `ibm_cloud` | IBM Cloud |
frzifus marked this conversation as resolved.
Show resolved Hide resolved
| `tencent_cloud` | Tencent Cloud |

`cloud.platform` has the following list of well-known values. If one of them applies, then the respective value MUST be used, otherwise a custom value MAY be used.
Expand All @@ -53,6 +54,7 @@
| `gcp_kubernetes_engine` | Google Cloud Kubernetes Engine (GKE) |
| `gcp_cloud_functions` | Google Cloud Functions (GCF) |
| `gcp_app_engine` | Google Cloud App Engine (GAE) |
| `ibm_cloud_openshift` | Red Hat OpenShift on IBM Cloud |
| `tencent_cloud_cvm` | Tencent Cloud Cloud Virtual Machine (CVM) |
| `tencent_cloud_eks` | Tencent Cloud Elastic Kubernetes Service (EKS) |
| `tencent_cloud_scf` | Tencent Cloud Serverless Cloud Function (SCF) |
Expand Down